Skip to content

Conversation

@lnicola
Copy link
Member

@lnicola lnicola commented Dec 9, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2025

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Dec 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the main branch for this repo, but this one is against beta. Please double check that you specified the right target!

@lnicola
Copy link
Member Author

lnicola commented Dec 9, 2025

@bors rollup=always

(EDIT: not actually sure whether beta backports can be rolled up)

@jieyouxu
Copy link
Member

jieyouxu commented Dec 9, 2025

EDIT: not actually sure whether beta backports can be rolled up

They must not be rolled up (for directly beta-branch targetting PRs, not the main-targetting ones that are intended to be cherry-picked after they merge into main), because PRs in a rollup target main, but this beta backport is targetting the beta branch directly.

@bors rollup=never

@jieyouxu
Copy link
Member

jieyouxu commented Dec 9, 2025

@lnicola also wait, is this intended for 1.92.0

@lnicola
Copy link
Member Author

lnicola commented Dec 9, 2025

No, for 1.93.

@jieyouxu
Copy link
Member

jieyouxu commented Dec 9, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the main branch for this repo, but this one is against beta. Please double check that you specified the right target!

(Also random tip: IIRC this message will be suppressed if you write "[beta]" in the backport PR title :D)

rust/triagebot.toml

Lines 1402 to 1408 in 018d269

[[assign.warn_non_default_branch.exceptions]]
title = "[beta"
branch = "beta"
[[assign.warn_non_default_branch.exceptions]]
title = "[stable"
branch = "stable"

@lnicola lnicola changed the title Backport rust-analyzer proc macro server "disable postcard use temporarily" [beta] Backport rust-analyzer proc macro server "disable postcard use temporarily" Dec 9, 2025
@lnicola
Copy link
Member Author

lnicola commented Dec 9, 2025

So how does this work, do we have to wait until 1.92 comes out, or can we merge it now?

@jieyouxu
Copy link
Member

jieyouxu commented Dec 9, 2025

So how does this work, do we have to wait until 1.92 comes out, or can we merge it now?

My understanding this that this should be okay to merge since we prepped the beta branch already as part of the release process (#149760), but worth double-checking with release team #t-release1

EDIT: #t-release > 1.93-targetting r-a beta backport

Footnotes

  1. Since I have to wrap my head around which is which every time 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants